fix: remove trailing comma in UniqueStringList.ToString#3309
Merged
yhl25 merged 1 commit intonumaproj:mainfrom Mar 13, 2026
Merged
fix: remove trailing comma in UniqueStringList.ToString#3309yhl25 merged 1 commit intonumaproj:mainfrom
yhl25 merged 1 commit intonumaproj:mainfrom
Conversation
…t.ToString ToString was appending a comma after every element, producing a trailing comma (e.g. "a,b,c," instead of "a,b,c"). Switch to strings.Builder to fix the output and avoid repeated string allocations. Signed-off-by: Sri Harsha Yayi <sriharshayayi@gmail.com>
syayi
force-pushed
the
fix/uniq-str-list-tostring-trailing-comma
branch
from
fdc4770 to
baeaf7b
Compare
yhl25
approved these changes
Mar 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
+ Coverage 81.08% 81.11% +0.02%
==========================================
Files 316 316
Lines 72631 72633 +2
==========================================
+ Hits 58896 58915 +19
+ Misses 13178 13161 -17
Partials 557 557 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToString()was appending a comma after every element, producing a trailing comma (e.g."a,b,c,"instead of"a,b,c")strings.Builderto fix the output and avoid repeated string allocationsToString()Test plan
TestUniqueStringList_ToStringcovers empty list, single element, and multi-element casespkg/shared/utilcontinue to pass